Update with-test lower bound to ocaml.5.2.0 - #51
Merged
Merged
Conversation
…ttling some 5.2/5.4/5.5 output disagreement
…mote cram results
Owner
Author
|
ocaml-ci seems to be moving with the
We are not hitting a ppc64 anymore, likely due to not blowing the stack on ocaml.5.5.x there (as opposed to on 4.14.x) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the cram tests so that they run and pass on 5.2.0-5.5.0.
The normalized program is printed differently (with more type annotations) starting from 5.2.0, so this seems the best we can do with limited effort.
The indentation of
Here is an example of a case that is not matched: ...changed across these versions.I've settled it by punting, i.e., passing
-w -partial-matchduneandocamlcmanually(silencing different output is also a way to normalize 😅 )