Repository navigation
Record that rmcp merged the float fix Codex was waiting on - #998
Conversation
modelcontextprotocol/rust-sdk#1300 merged on 2026-09-27 as e02efbfc and closed rust-sdk#1299; no rmcp tag carries it yet. The entry for the non-integer annotation priority now says so, in the summary row and in its facts, and states the cause the register used to get wrong: not a patched rmcp in the ChatGPT.app bundle, but serde_json's arbitrary_precision, which Cargo turns on for rmcp inside codex-cli and under which a buffered decimal no longer decodes into an f32. The Codex workaround stays until a Codex built on the fix is what ChatGPT.app ships.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: jmrplens/gitlab-mcp-server/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe upstream bug table and Codex entry now link the reported issue and its cause, record the merged but unreleased ChangesCodex bug documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change only updates documentation about a known upstream issue's status; it carries no functional risk. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkResolution Complete the Description, Related Issue, Type of Change, Changes Made, and How to Test sections. Select Documentation update, replace the placeholder issue reference with the relevant issue or PR reference, and complete applicable checklist items. Keep N/A for Breaking Changes / Migration Notes if no migration is required.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



The fix for the Codex float bug is merged upstream: modelcontextprotocol/rust-sdk#1300 landed on 2026-09-27 as
e02efbfcand closed modelcontextprotocol/rust-sdk#1299. This brings the register's entry for it up to date.The summary row and the entry's facts now say reported (the Codex issue and the rmcp issue), in review (the rmcp pull request, merged) and merged in no tag, since rmcp 3.4.1 was cut on 2026-09-23 and does not contain it. The entry says what reaching users takes: an rmcp release carrying the fix, a Codex release built on it, and a ChatGPT.app that bundles that Codex.
It also corrects the cause the entry used to state. It put the defect in a patched rmcp inside the ChatGPT.app bundle. The real cause is serde_json's
arbitrary_precision: Cargo turns it on for rmcp inside codex-cli, throughstarlark0.14.2 andcodex-exec-server-protocol, and under it a buffered decimal is replayed as serde_json's private number map, which a plainf32refuses. The entry now explains that, and says how the first reading went wrong.The Codex workaround in
internal/clientcompatstays, and the entry now says what retires it: a Codex built on the fix being what ChatGPT.app ships, not merely a release.What I ran:
format_md_tables --check, markdownlint on the file,make check-doc-links,make check-em-dash,audit_doc_tool_names --check,gen_stats -check,make check-llmsandmake check-site-stats, all clean; no generated artifact moves.Part of #959.