Skip to content

Packaging and libwcwidth fixes - #253

Merged
jquast merged 3 commits into
masterfrom
jq/libwcwidth-fixes
Sep 17, 2026
Merged

jquast merged 3 commits into
masterfrom
jq/libwcwidth-fixes

Conversation

@jquast

@jquast jquast commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Packaging: Drop ucs-detect/data/*.yaml from sdist, this is almost 25MB unpacked and will only grow.
If any downstream re-distributors wish to re-execute "tox -e update", then, they can use our git
repository, tags, and git submodules. For python sdist, the ability to "build from source", there is
no need to include 25MB of data used for a code generation step that is not typically executed.

libwcwidth:

Bugfix GB9b: boundary_before() recursed on the Prepend's byte offset, which
resolves the codepoint before it, landing one cluster too far left.
Bugfix ITU T.416 colon-format SGR colors re-emitted with ';', shifting RGB.
Bugfix clip() dropped sequences outside the window, and SGR inside it.
clip() bounds each grapheme iterator to the next ESC; it was quadratic.
18MB of terminal measurements, needed only to regenerate the Corrections
tables from the git submodule.
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a29c0e1) to head (dd42acb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1982      1982           
  Branches       463       463           
=========================================
  Hits          1982      1982           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 116 untouched benchmarks
🆕 3 new benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 test_clip_cjk_paragraph N/A 11.7 ms N/A
🆕 test_clip_cjk_paragraph_overtyping N/A 15 ms N/A
🆕 test_clip_emoji_zwj N/A 1.6 ms N/A

Comparing jq/libwcwidth-fixes (dd42acb) with master (a29c0e1)

Open in CodSpeed

@jquast
jquast merged commit 69d5c1e into master Sep 17, 2026
36 checks passed
@jquast
jquast deleted the jq/libwcwidth-fixes branch September 17, 2026 17:48
jquast added a commit that referenced this pull request Sep 17, 2026
libwcwidth has not been released, so its changes have no audience for a
history entry.  Drops everything that came in with #253, and the link
targets left unreferenced by their removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant