Packaging and libwcwidth fixes - #253
Merged
Merged
Conversation
Bugfix GB9b: boundary_before() recursed on the Prepend's byte offset, which resolves the codepoint before it, landing one cluster too far left.
Bugfix ITU T.416 colon-format SGR colors re-emitted with ';', shifting RGB. Bugfix clip() dropped sequences outside the window, and SGR inside it. clip() bounds each grapheme iterator to the next ESC; it was quadratic.
18MB of terminal measurements, needed only to regenerate the Corrections tables from the git submodule.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1982 1982
Branches 463 463
=========================================
Hits 1982 1982 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Performance Changes
Comparing |
jquast
added a commit
that referenced
this pull request
Sep 17, 2026
libwcwidth has not been released, so its changes have no audience for a history entry. Drops everything that came in with #253, and the link targets left unreferenced by their removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging: Drop ucs-detect/data/*.yaml from sdist, this is almost 25MB unpacked and will only grow.
If any downstream re-distributors wish to re-execute "tox -e update", then, they can use our git
repository, tags, and git submodules. For python sdist, the ability to "build from source", there is
no need to include 25MB of data used for a code generation step that is not typically executed.
libwcwidth: