fix(ui): adjust faq accordion scroll target to prevent clipping - #2476
Open
kunalverma2512 wants to merge 2 commits into
Open
kunalverma2512 wants to merge 2 commits into
kunalverma2512 wants to merge 2 commits into
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 695 695
Branches 215 215
=========================================
Hits 695 695 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Screenshots/videos:
Before changes :
After changes :
After changes (phone view) :
If relevant, did you update the documentation?
Not applicable
Summary
When expanding an FAQ item, the automatic scroll behavior currently calculates its offset by targeting the inner answer block. This causes the scroll to overshoot and clip the top of the accordion card underneath the sticky navigation bar.
To fix this without losing the helpful scrolling behavior, this PR simply moves the HTML
idattribute from the inner answer block up to the outer wrapper of the accordion item. This ensures the scroll calculation perfectly aligns the top of the entire question card below the header. As an added bonus, it also fixes native URL deep-linking so direct links to FAQs jump to the top of the card instead of the answer text.Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.