Point the test site's code samples at the test site - #275
Merged
Merged
Conversation
Both deploy workflows set NEXT_PUBLIC_BASE_URL, but nothing read it, so samples copied from datapipe-test.web.app fell through to the packages' built-in pipe.jspsych.org and wrote to production. The API reference printed the production origin too. lib/base-url.js now reads it, with production as the fallback. The API reference uses it, and on any non-production build every sample passes the deployment explicitly (base_url for the extension, baseURL for datapipe-client). Production samples are unchanged. Fixes #246 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246.
Why
Both deploy workflows set
NEXT_PUBLIC_BASE_URL, but nothing read it. The code samples ondatapipe-test.web.apppassed no base URL, so they fell through to the packages' built-inhttps://pipe.jspsych.org. A tester who copied one wrote data to production, against real researchers' experiments. The API reference also printed the production origin.What changed
lib/base-url.js(new) readsNEXT_PUBLIC_BASE_URL, falling back to production when it is unset or blank. It is a literalprocess.envreference because Next.js inlines it at build time.ApiPrimitives.jsuses it instead of a hardcoded URL.base_urlin the extension params, and as an option tosaveBase64DataandgetCondition.datapipe-client:baseURLonsaveData,createSession,saveBase64DataandgetCondition.No package release is needed.
@jspsych/extension-pipe@0.2.0anddatapipe-clientalready accept these options.Testing
__tests__/base-url.test.jscovers the fallback, trailing slashes, and when an override is emitted.extension-snippet.test.jsnow executes the sample with an override and checks thatbase_urlreaches the extension.next buildwithNEXT_PUBLIC_BASE_URL=https://datapipe-test.web.app: the prerendered API reference has nopipe.jspsych.org/api, and the docs' extension samples carry the test URL.baseURLand parse.🤖 Generated with Claude Code