Conversation
The token input was type="password" with autocomplete="off", which Chrome ignores on password fields: it filled in the saved DataPipe login, the pasted token landed after it behind the mask, and Dataverse rejected the combined string (#278, which then worked in Firefox). Masking bought little -- the installation shows the token in the clear -- and hid exactly the mistake that broke the connect. Use a text field with autofill, autocorrect, and password-manager filling turned off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #278.
Why
The reporter of #278 could not connect Harvard Dataverse from Chrome, even with a freshly generated token. The same token worked in Firefox.
The token field was
type="password"withautocomplete="off". Chrome ignoresautocomplete="off"on password fields and fills in the saved DataPipe login password. The field is masked, so a researcher who pastes without clearing it sends their password followed by the token. Dataverse rejects that, and the dashboard shows "did not accept the token." This is the most likely cause; the reporter hasn't confirmed it.Masking protects little here. The installation shows the token in plain text, and we never display it after saving. It did hide the mistake that broke the connect. A password field could also lead Chrome to offer to save the token as the site password, replacing the researcher's saved login.
What
autoComplete="off",autoCapitalize="off",autoCorrect="off"andspellCheck={false}.data-1p-ignoreanddata-lpignore="true"so 1Password and LastPass don't fill the field.Not checked in a real Chrome yet; the new jsdom test only checks the field's attributes. Worth trying on the test site with a saved login before merging.
Related: #280, which logs what the Dataverse server returns when it rejects a token.
🤖 Generated with Claude Code