Repository navigation
Let division by an AffExpr stay an AffExpr when it has all-0 coefficients - #4262
Closed
acostarelli wants to merge 2 commits into
Closed
acostarelli wants to merge 2 commits into
acostarelli wants to merge 2 commits into
Conversation
Member
|
Closing in favor of #4263. I've added you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior:
This branch changes so that the return is an AffExpr when the RHS has all-0 coefficients.
Tests are currently broken because now the return type from division cannot be inferred, which seems like a valid reason not to do this.