Skip to content

Nothing stops the examples from rotting #56

Description

@k0d13

examples/* is outside pipeline.yml by choice, so no CI job builds or typechecks them. Everything in there was verified by hand in #51 and is correct as of that PR, but the next change to a package API can break all eight without anything noticing.

The examples are also the only runnable demonstration of several parts of the public surface — the whitespace prop, the WebExtension JSON dialect, withSay on Carbon commands, custom formatters and transformers — so a broken example is a broken piece of documentation.

Cheapest useful job: pnpm --filter "./examples/*" check, which is tsc --noEmit everywhere and catches nearly all realistic breakage.

Adding extract on top would additionally prove every config still loads and every bucket glob still matches, at the cost of needing the catalogues to come out unchanged (git diff --exit-code) to be meaningful.

The heavier ones are best left out: Expo native builds, wrangler deploy, and loading the extension unpacked all need toolchains or credentials CI does not have.

Deferred deliberately in #51 rather than forgotten — opening this so the decision is visible.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

examplesUpdates or additions to example appstestsModifications, additions, or fixes related to testing

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions