lint: fix arc-lint breakage on main (suite exclude + skaffold indent + copy.bara dup)#86
lint: fix arc-lint breakage on main (suite exclude + skaffold indent + copy.bara dup)#86ConstanzeTU wants to merge 1 commit into
Conversation
…copy.bara dup) Main's lint broke after #68/#83 merged the adaptive_export_loadtest tree: - .arclint didn't exclude the suite/ nested go module ('aeloadsuite') → golangci-lint typecheck fails on it from the root module (tools/loadgen/ was already excluded). - src/e2e_test/adaptive_export_loadtest/skaffold.yaml: requires: block indented wrong for yamllint (indent-sequences:false; expected 0/4, was 2/6). - tools/private/copybara/copy.bara.sky: malformed duplicate line (md_udtfs/** + shared/manager BUILD.bazel concatenated behind a comment) rode in via #83. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017k7uYSNUctQvkTAZYJbaB3
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main's lint broke after #68/#83 merged the
adaptive_export_loadtesttree. Three fixes:.arclint— exclude thesrc/e2e_test/adaptive_export_loadtest/suite/nested go module (aeloadsuite). golangci-lint typecheck-fails on it from the root module (main module (px.dev/pixie) does not contain package …/suite). The siblingtools/loadgen/was already excluded; this mirrors it.src/e2e_test/adaptive_export_loadtest/skaffold.yaml— reindent therequires:block toindent-sequences: false(yamllint: expected 0/4, was 2/6). yamllint clean now.tools/private/copybara/copy.bara.sky— drop a malformed duplicate list line (md_udtfs/**+shared/manager/BUILD.bazelconcatenated behind a comment) that rode in via Restore fork infra (rebased onto current main) — supersedes #72 #83; both paths are already listed correctly above it.Verified:
yamllintclean on skaffold.yaml; the.arclintexclude structurally removes the golangci-lint typecheck failure on the nested module.🤖 Generated with Claude Code