Skip to content

lint: fix arc-lint breakage on main (suite exclude + skaffold indent + copy.bara dup)#86

Open
ConstanzeTU wants to merge 1 commit into
mainfrom
fix/arclint-suite-exclude
Open

lint: fix arc-lint breakage on main (suite exclude + skaffold indent + copy.bara dup)#86
ConstanzeTU wants to merge 1 commit into
mainfrom
fix/arclint-suite-exclude

Conversation

@ConstanzeTU

Copy link
Copy Markdown

Main's lint broke after #68/#83 merged the adaptive_export_loadtest tree. Three fixes:

  1. .arclint — exclude the src/e2e_test/adaptive_export_loadtest/suite/ nested go module (aeloadsuite). golangci-lint typecheck-fails on it from the root module (main module (px.dev/pixie) does not contain package …/suite). The sibling tools/loadgen/ was already excluded; this mirrors it.
  2. src/e2e_test/adaptive_export_loadtest/skaffold.yaml — reindent the requires: block to indent-sequences: false (yamllint: expected 0/4, was 2/6). yamllint clean now.
  3. tools/private/copybara/copy.bara.sky — drop a malformed duplicate list line (md_udtfs/** + shared/manager/BUILD.bazel concatenated behind a comment) that rode in via Restore fork infra (rebased onto current main) — supersedes #72 #83; both paths are already listed correctly above it.

Verified: yamllint clean on skaffold.yaml; the .arclint exclude structurally removes the golangci-lint typecheck failure on the nested module.

🤖 Generated with Claude Code

…copy.bara dup)

Main's lint broke after #68/#83 merged the adaptive_export_loadtest tree:
- .arclint didn't exclude the suite/ nested go module ('aeloadsuite') → golangci-lint
  typecheck fails on it from the root module (tools/loadgen/ was already excluded).
- src/e2e_test/adaptive_export_loadtest/skaffold.yaml: requires: block indented
  wrong for yamllint (indent-sequences:false; expected 0/4, was 2/6).
- tools/private/copybara/copy.bara.sky: malformed duplicate line (md_udtfs/** +
  shared/manager BUILD.bazel concatenated behind a comment) rode in via #83.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017k7uYSNUctQvkTAZYJbaB3
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ConstanzeTU, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 089dcc02-ff3f-42bc-a597-ddb4aa49b2ec

📥 Commits

Reviewing files that changed from the base of the PR and between b51c76b and 2aba6c0.

📒 Files selected for processing (3)
  • .arclint
  • src/e2e_test/adaptive_export_loadtest/skaffold.yaml
  • tools/private/copybara/copy.bara.sky
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/arclint-suite-exclude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant