Repository navigation
Recommendation subscriptions: dry-run round trip and update assertions - #119
Merged
kLOsk merged 1 commit intoOct 28, 2026
Merged
Conversation
Follow-up to kLOsk#118 (review notes): a test drafts a pause and runs confirm_and_apply(dry_run=True) through the real validate-only path, checking one validated call, validate_only on the request, and an update of the planned resource to PAUSED; another asserts every operation is an update on the planned resource name. Tests only.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #118, covering the two non-blocking review notes. Tests only; no code changes.
TestDryRunRoundTrip: drafts a pause withdraft_recommendation_subscriptions, then callsconfirm_and_apply(dry_run=True)through the real validate-only path. The suite's offline stub is swapped for_execute_plan(..., validate_only=True)with a fake Ads client, the same waytest_validate_only.pydoes it. It asserts:DRY_RUN_SUCCESSwithvalidated_calls: 1;validate_onlyset on the request;updateof the planned resource name toPAUSED.test_each_operation_updates_the_planned_resource: with two types, every operation is anupdate(checked through the proto oneof), and the resource names match the plan in order.uv run pytest: all green locally.