Repository navigation
feat(engines): drop the proton engine and its image - #33
Merged
Merged
Conversation
The mirrors that copy the owner's accounts left the org and keep their own copies of the proton parts. lib now holds only what the rsync mirrors use. - Delete engines/proton.yml, docker/proton.Dockerfile, docker/s3.py and examples/proton/. - Drop the proton_drive_cli, age and python tables from the lock. Only the proton image read them. The rsync image takes python3 from apt. - ci and release build the rsync variant only. The guard steps run without a variant condition. - The chain-file fixture names katoptra/ctan. - README, CLAUDE.md and CONTRIBUTING.md describe one engine, one image and one example. toolbox.yml changes in comments only, and engines/rsync.yml does not change. Thus, the render of each public mirror stays the same. The release is v2.10.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change
lib keeps only the parts that the rsync mirrors use. The mirrors that copy the owner's accounts left the org, and they keep their own copies of the proton parts. A run of a public mirror does not change.
engines/proton.yml,docker/proton.Dockerfile,docker/s3.pyandexamples/proton/.toolchain.lock.toml: remove theproton_drive_cli,ageandpythontables. Only the proton image read them. The rsync image installspython3from apt. Theubuntu,task,opandawsclitables stay. No file reads a removed table (git grepof eachlockcall: onlytask.*,op.*andawscli.*).ci.ymlandrelease.yml: the matrix has onlyrsync. The two guard steps inci.ymlhave noif:, and they run in each job..github/chain-file.sh: the first test case nameskatoptra/ctan. The chain stays, because an rsync fill also uses it.toolbox.yml: the comment that lists the verb names of the engines names only the rsync engine. No command changes.README.md,CLAUDE.mdandCONTRIBUTING.mddescribe one engine, one image and one example. The headings that the mirror repositories link to do not change.The release after this merge is v2.10.0. The
toolbox.ymldiff has only comment lines, andengines/rsync.ymldoes not change. Thus, the render of each public mirror onv2stays the same.README headings:
#secrets,#storage,#the-toolbox,#the-rsync-engine,#when-a-run-fails,#content-types,#r2-specifics,#monitoringand#rules-a-mirror-keeps.Storage and operations
None. No step reads or writes a bucket.
Test plan
sh .github/validate-vars.sh --checksh .github/chain-file.sh --checksh docker/gpg-gate-check.shsh .github/op-retry-check.shtask checkinexamples/rsync, in a localrsync-devimage: the render agrees withrender.txt.git grep -n -i -E 'proton|dropbox|age-keygen|session-seal'gives no line.tools,checkandofflineinexamples/rsync.rm -rf .task/remote && task checkshows no render diff.