Repository navigation
fix(build): move kotlinx-coroutines-test from commonMain to commonTest - #258
Open
muthuraj57 wants to merge 1 commit into
Open
muthuraj57 wants to merge 1 commit into
muthuraj57 wants to merge 1 commit into
Conversation
…me one It was declared in commonMain, so every consumer shipped it, and its TestMainDispatcherFactory service can shadow the real Main dispatcher when service files are merged (fat jars), breaking Dispatchers.Main (kdroidFilter#250). Moved to commonTest; no main source uses it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #250.
kotlinx-coroutines-testwas declared incommonMain, so every consumer shipped it. Besides the size, itsTestMainDispatcherFactoryservice can shadow the real Main dispatcher when service files are merged (e.g. a fat jar keeps only oneMETA-INF/services/kotlinx.coroutines.internal.MainDispatcherFactory); on Linux this made everyDispatchers.Maincall throw "Module with the Main dispatcher is missing". No main source uses it; it moves tocommonTest.Test plan
:mediaplayer:dependencies --configuration jvmRuntimeClasspathno longer lists it:mediaplayer:compileKotlinJvm :mediaplayer:compileTestKotlinJvmpass