Skip to content

fix(macos): seek HLS streams exactly #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
comprido96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(macos): seek HLS streams exactly #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mediaplayer/src/jvmMain/native/macos/NativeVideoPlayer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,10 +1311,10 @@ class MacVideoPlayer {
guard let player = player else { return }
let newTime = CMTime(seconds: time, preferredTimescale: 600)

// For HLS, use tolerance for more efficient seeking
// HLS seeks are exact: a tolerance lets AVPlayer land on the nearest keyframe, up to a second
// away from where the user dropped the slider
if isHLSStream {
let tolerance = CMTime(seconds: 1.0, preferredTimescale: 600)
player.seek(to: newTime, toleranceBefore: tolerance, toleranceAfter: tolerance)
player.seek(to: newTime, toleranceBefore: .zero, toleranceAfter: .zero)
} else {
player.seek(to: newTime)

Expand Down