Repository navigation
fix(macos): report the audio format of HLS streams - #262
Open
comprido96 wants to merge 1 commit into
Open
comprido96 wants to merge 1 commit into
comprido96 wants to merge 1 commit into
Conversation
metadata.audioChannels and audioSampleRate were read from the asset's tracks, which an HLS asset does not list: both stayed null for every HLS stream, even with an AAC track playing. For HLS, read them from the AVPlayerItem's tracks once the item has loaded them, and backfill the metadata from the position poll, since that happens after open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS,
metadata.audioChannelsandmetadata.audioSampleRatestaynullfor every HLS stream, even with an AAC track playing. They are read from the asset's tracks, and an HLS asset lists none. A caller cannot tell whether to offer a mute control.Fix
AVPlayerItem.tracksand read the channel count and sample rate from the audio track's format description once the item has loaded it.MacVideoPlayerStatebackfillsmetadata.audioChannels/audioSampleRatefrom its position poll, since the tracks arrive after open.Testing
Tested on macOS 26 (Apple Silicon), against Frigate 0.17 HLS VOD clips (fMP4 segments,
EXT-X-DISCONTINUITYbetween segments, keyframes every 2 s) from two cameras: H.264 Baseline 1280×720 25 fps, and H.264 High 2560×1920 ~30 fps VFR with AAC.NativeVideoPlayer.swift:getAudioChannels()returns 1 on both cameras (before: 0).:mediaplayer:jvmJar); I have not exercised it in an app with exactly this code.Prepared with an AI coding assistant (Claude Code) while integrating the library into a macOS desktop app, and tested as described above. Happy to adjust, split or drop anything that does not fit the project.
🤖 Generated with Claude Code