test(e2e): poll Files list after upload (read-after-write staleness)#523
Merged
Conversation
The nightly's remaining flake after #521 was `TestFullE2E` failing on "uploaded file must appear in list": the just-uploaded file was missing from an immediate tag-filtered Files list. The upload is durable (the facade path round-trips read_bytes right before), but the tag index is read-after-write eventually consistent and lags a few seconds -- so it passed locally and in some CI runs, failed in others. Poll the list until the file appears (bounded ~30s) instead of asserting the first read, in both the SDK-facade round-trip (kbc.files.list) and the CLI file-ops flow (storage files --tag). Same pattern already used for the add-column / swap read-after-DDL lags. Test-only. make check green (4648 passed).
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #521. The nightly's last remaining failure was
TestFullE2Eintermittently failing on "uploaded file must appear in list" — the just-uploaded file was absent from an immediate tag-filtered Files list. The upload is durable (the facade path round-tripsread_bytesright before the list), but the tag index is read-after-write eventually consistent and lags a few seconds, so it passed locally + in some CI runs and failed in others (also seen in pre-token-break June nightlies).Poll the list until the file appears (bounded ~30s) instead of asserting the first read, in both spots that do upload→immediate-list: the SDK-facade round-trip (
kbc.files.list) and the CLI file-ops flow (storage files --tag). Same pattern already used for the add-column/swap read-after-DDL lags in #521.Test-only;
make checkgreen (4648 passed). After this, the manual nightly run 29915860766 had exactly this one failure remaining (my four #521 fixes were green: 114 passed / 1 failed).