Repository navigation
fix(map): rooms face their screens, arms clamp at the back edge, Add on it lists things not on the map yet (#150, #151, #152) - #156
Merged
Conversation
A room opens with the camera on the front side of its screens (monitors, TVs, laptops, weighted by width), at the map's usual half-quarter angle; a room with none keeps the current turn. Turning inside a room (buttons or two fingers) is remembered per room on this device and wins next time. Try the map shares the engine, so it behaves the same. Closes #150 Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
Put on... and Add on it stand an arm at the back edge of a top (the side away from the chair, opposite the front its turn defines): centred, else a back corner, else anywhere along the back. It faces the desk's way, so its monitors hang over the desk in front of the pole; turning the desk turns the stack and keeps it at the back. Dragging an arm onto a desk snaps it to the back edge and slides it along it. Closes #151 Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
…e step (#152) Add on it also lists, under "Not on the map yet", the room's things that aren't on the map, each with the shape it would get (D249) and only when that shape could be carried and fits the holder. Picking one puts it on the map and on the holder in the same change: one Done, one Undo. Viewers are unchanged; Try the map does the same. The spec gets one D237 amendment row for #150-#152. Closes #152 Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150, closes #151, closes #152.
Three map follow-ups to #137, one commit each. Ships in 1.10.6.
What a person can do
Try the map does all three (it shares the engine and the layout code).
How it works
kept.map.turns(local storage, newest 200, failures ignored) and wins next time; the camera takes the short way round.freeSpottries the back row first for an arm on a top (middle, nearest back corner, then anywhere along the back);dropOnsnaps an arm to the back edge and turns it to the holder's way. Saved layouts load as saved.offMapForbuilds each off-map thing as the item it would become (thingItem, the D249 shape: chosen, saved, else the first suggestion) and keeps it only if that shape could be carried and fits the holder.addOnputs both kinds on in one plan change. The empty states no longer say "put one on the map first".Tested
facing.test.ts; arm back-edge cases inholders.test.ts, including a turned desk, the corner fallback and dragging; Add on it with off-map things, the one-step placement and the saved body input-on.test.tsx).sample.test.ts6 passed;node scripts/check-try-kept.mjs: every walk passed; docs build OK.ci-local.sh --only lint,typecheck,driftOK;check-i18nevery message in;check-logical-cssOK.