Repository navigation
Conversation
The interface name from the command line was copied into a fixed size netlink request without a length check, so a name longer than the 256-byte attribute buffer overflowed the stack. Coverity Scan reports it as a string of unknown size passed to syslog (CID 564681). Reject names the kernel would not accept anyway, before using them. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
If the new peers file could not be put in place, pppd was restarted on the old one and the change reported as applied. Coverity Scan reports the unchecked rename() and remove() (CID 564682, 564679). Fail the change if rename() fails. Failing to remove an unchanged scratch file is harmless, the next change overwrites it. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The timeouts keep a stuck iitod from blocking confd, so the call must not go ahead without them. Coverity Scan reports the unchecked setsockopt() calls (CID 564680). Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes to the new
pppmontool, introduced in this release cycle.Checklist
Tick relevant boxes, this PR is-a or has-a: