chore: drop .prettierignore - #110
Merged
Merged
Conversation
The `doc/api/**` exclusion was speculative. Dartdoc output is never generated into these repos, so the file only added noise to the canonical markdown config set. Removing it here keeps every repo's config byte-identical, which is the point of the standardization -- the Tier 1 repos were never given this file.
📦 Dependency Lower-Bound Validation Summary✅
|
| Dependency | Declared Constraint | Declared Floor | Resolved Version | Status |
|---|---|---|---|---|
args |
^2.0.0 |
2.0.0 |
2.0.0 |
Exact Floor |
build_cli_annotations |
^2.0.0 |
2.0.0 |
2.0.0 |
Exact Floor |
shelf |
^1.0.0 |
1.0.0 |
1.0.0 |
Exact Floor |
shelf_static |
^1.0.0 |
1.0.0 |
1.0.0 |
Exact Floor |
📊 Cognitive Complexity AnalysisNet Delta: 0 | Added: 0 | Increased: 0 | Improved: 0 | Violations: 0 No modified Dart declarations detected. |
kevmoo
added a commit
to kevmoo/analytica.dart
that referenced
this pull request
Sep 12, 2026
…eport (#117) ## Problem `lower_bound` and `cognitive_complexity` unconditionally posted their sticky summary comment on every PR run, including runs with zero findings. Example: kevmoo/dhttpd#110 received two `github-actions[bot]` comments, both empty ("Status: Clean, 4 deps all Exact Floor" and "Net Delta: 0 | Added: 0 | Increased: 0 | Improved: 0 | Violations: 0"). Each one is an email notification for no information. ## Change The Dart CLIs now own the "is this worth a comment?" decision: - `lower_bound`: skips writing the `--comment-output` file when every validated package is clean. - `cognitive_complexity`: skips writing the comment file when there are zero violations **and** zero complexity increases. The comment body is now decoupled from `$GITHUB_STEP_SUMMARY`, so the full table still lands in the job summary regardless. Both `action.yml` scripts treat a missing/empty comment file as "clean": - **No existing sticky comment** → post nothing. Silence is the clean signal. - **Existing sticky comment** (from an earlier dirty push) → `PATCH` it in place via `gh api` to a short resolved/clean status block. Deliberately **not** deleting stale comments: a disappearing comment is more confusing than an updated one, and the notification cost has already been paid. ## Blast radius⚠️ Every consumer repo references these actions as `uses: kevmoo/analytica.dart/packages/<name>@main`, so merging this goes live across ~30 repos immediately with no per-repo PRs. ## Tests - `lower_bound`: split the sticky-comment test into explicit clean (no file written) and dirty (file written) cases; fixed the dirty fixture to actually fail lower-bound analysis (exit 70). - `cognitive_complexity`: added `writes no comment file when run is clean`, using an empty commit so `HEAD~1` resolves with a zero-delta diff. - `dart test` passes in both packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doc/api/**exclusion was speculative. Dartdoc output is never generatedinto these repos, so the file only added noise to the canonical markdown
config set.
Removing it here keeps every repo's config byte-identical, which is the point
of the standardization -- the Tier 1 repos were never given this file.