chore(mac): merge preprocessor constants 🧽 - #16529
Merged
Merged
Conversation
SabineSIL
added
developer/
mac/
common/
developer/compilers/
core/
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
removed
the
user-test-missing
SabineSIL
force-pushed
the
chore/mac/16345/merge-preprocessor-constants
branch
from
September 4, 2026 13:24
6528c9a to
ba4aa6a
Compare
SabineSIL
marked this pull request as ready for review
September 4, 2026 13:46
SabineSIL
force-pushed
the
chore/mac/16345/merge-preprocessor-constants
branch
from
September 4, 2026 14:02
5519550 to
ba628b5
Compare
mcdurdin
approved these changes
Sep 5, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
LGTM, nice and clean in the end!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #14360 a new file km_vkey.h is introduced from which all VK_* will be imported.
This is completed for windows/linux.
On mac km_vkey.h should be used instead of
Fixes: #16345
See-also: #12434
See-also: #14360
Test-bot: skip