Repository navigation
fix/status-and-pfp-sync-both-ways - #168
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DannySS123
reviewed
Mar 16, 2025
| }, | ||
| }, | ||
| status: | ||
| currentUser.profilePicture.status === 'PENDING' |
Contributor
There was a problem hiding this comment.
Ezt egy fv visszaadhatná, 2 ternary egymásban már elég olvashatatlan
Contributor
There was a problem hiding this comment.
String helyett jobb lenne használni az ApplicationStatus enumot
DannySS123
reviewed
Mar 16, 2025
| if (status !== ProfilePictureStatus.PENDING) { | ||
| await this.applicationService.setActiveApplicationsStatus(id, status, tx); | ||
| let appStatus = status; | ||
| if (status === 'PENDING') { |
Contributor
There was a problem hiding this comment.
String helyett jobb lenne használni az ApplicationStatus enumot
mozsarmate
force-pushed
the
full-status-sync
branch
from
September 14, 2026 15:50
881ddc0 to
669424b
Compare
- Remove duplicate DefaultArgs import - Forward changedById into setActiveApplicationsStatus from setProfilePictureStatus so profile-picture status changes are attributed in the application audit log - Lock rows with SELECT ... FOR UPDATE in bulkUpdate() before reading statuses, preventing a race where a concurrent status change could make the audit log record a stale previousStatus - Fix Buffer.from(...) calls in exportProfilePictures/findProfilePicture to respect byteOffset/byteLength instead of assuming a zero-offset backing ArrayBuffer
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.