Repository navigation
Feat: audit log for status changes - #185
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mozsarmate
force-pushed
the
feat/audit-log
branch
from
September 7, 2026 20:00
2f277c9 to
3cf9b88
Compare
mozsarmate
force-pushed
the
feat/audit-log
branch
from
September 7, 2026 20:02
3cf9b88 to
88d1356
Compare
Add an ApplicationStatusLog table that records every application status transition: timestamp, acting user and previous/new status. All status changes now go through a single helper that writes the log entry and refreshes the application's updatedAt. - new ApplicationStatusLog model + migration - applyStatusChange() centralises the status update and audit write - thread the acting user through the manual PATCH and the profile picture side effects; system-initiated changes are logged with a null user - GET /application/status-logs and GET /application/:id/status-logs
New /application-status-logs admin page that lists every application status change with the affected applicant, the acting user and the previous/new status. - client-side filtering (per-column text + date range), sorting and pagination, reusing the periods DataTable building blocks - useApplicationStatusLogs hook + entity type - linked from the admin dashboard
BarnaPuppi
reviewed
Sep 8, 2026
BarnaPuppi
left a comment
BarnaPuppi
left a comment
There was a problem hiding this comment.
Én a backendben nem láttam problémát, de pls valaki hozzáértő is nézze át azért
TGyAkos
requested changes
Sep 10, 2026
| try { | ||
| await this.prisma.application.findUniqueOrThrow({ where: { id } }); | ||
| } catch (e) { | ||
| if (e instanceof Prisma.PrismaClientKnownRequestError && e.code === 'P2025') { |
There was a problem hiding this comment.
Please wrap your magic values in local constants
TGyAkos
self-requested a review
September 10, 2026 20:39
drive by: extract prisma magic constants
- applyStatusChange now locks the row (SELECT ... FOR UPDATE) and re-reads its status inside the same transaction right before updating, instead of trusting a status snapshot the caller read earlier — fixes the audit log potentially recording the wrong previousStatus under concurrent updates. - getActiveApplications now accepts the transaction client so setActiveApplicationsStatus reads through the same tx it writes with. - Removed redundant manual updatedAt: new Date() now that Prisma's @updatedat already sets it on every update/updateMany. - Narrowed applyStatusChange's client param to PrismaTransactionClient (the PrismaService arm was never used). - Made SortableFilterableHeader/DateSortableFilterableHeader generic so application-status-logs/columns.tsx no longer needs an unsafe as unknown as Column<ApplicationEntity> cast.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added audit logs to make application status changes traceble. See more info in the git log of the commits.