fix: divide BBI by actual number of calc params - #840
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BBI averages its moving averages over a hard-coded
4instead of the actual number of parameters:masandmaxPeriodboth followcalcParams, but the divisor does not.Verified by execution:
calcParams: [3, 6, 12]on flat data at 100 yields75instead of100; with 5 params the result is 25% low.Impact
Any non-default
calcParamssilently produces wrong BBI values. Default[3, 6, 12, 24]is unaffected.Fix
maSum / params.length, guarded against an emptycalcParams(previously0/4 = 0; keep0rather thanNaN).One line, one file.