Org settings: upload and remove the organization logo - #35
Merged
Merged
Conversation
…n personal avatar upload
Member
Author
|
wasnt possible to upload avatars for orgs (I created https://www.underlay.org/centeroftrialanderror/ today, hence) also uploading avatars for your own account did nothing, bc it would try to upload to the /me organization |
Member
|
Awesome. It's Before Merging note isn't accurate - the buckets/domains are as they should be, this can merge as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The org avatar endpoint (
POST /api/accounts/:slug/avatar) already existed, but nothing in the UI used it. This adds the missing pieces.DELETE /api/accounts/:slug/avatar(owners only): clearsavatar_urland deletes the stored files.avatars/<orgId>/. The account-delete and org-delete routes now share the same cleanup helper./api/accounts/me/avatar, which matched/:slug/avatarwith slugmeand always returned "Organization not found". The personal picture comes from KF Auth anyway, so the page now says "Picture managed by your KF Account".Before merging
Production doesn't set
ASSETS_BASE_URL, so logo URLs default tohttps://assets.underlay.org, which probably doesn't serveS3_PUBLIC_BUCKETpublicly. If so, uploads succeed but the images show as broken. One of these needs to happen first:ASSETS_BASE_URLto the bucket's public URL, orTesting
Typecheck, lint, format check and unit tests (177) pass. I didn't try an upload against a running app with a real bucket.