Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
LoadInstallMetadata passed the raw file to json.Unmarshal, so a BOM written by Windows PowerShell 5.1 made 'knowns update' fail with: invalid character 'ï'. Strip a leading BOM before parsing and add a regression test (BOM and CRLF).
Set-Content -Encoding UTF8 adds a BOM on PowerShell 5.1. Use WriteAllText with a BOM-less UTF8 encoding instead. Refs knowns-dev#155.
anionzo
force-pushed
the
fix/update-metadata-bom
branch
from
October 30, 2026 16:48
1a45047 to
aca9ac9
Compare
- LoadQueue reads without the queue lock, so on Windows a rename over an open queue file fails with "Access is denied", and a read during the rename fails with a sharing violation. This surfaced as an intermittent TestSearchWithRuntimeDaemonRoutingSharesProviderAcrossConcurrentCalls failure. Retry both for a bounded time.
- Creating a symlink on Windows needs a privilege many machines lack. Every other symlink test in the repo skips in that case; this one failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
Type of Change
Checklist
Screenshots (if applicable)
Additional Notes