✨ Add parameter injection to harness prompt - #99
Closed
dymurray wants to merge 4 commits into
Closed
Conversation
Contributor
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe migration harness propagates runtime parameters into prompts and Goose, captures Goose output, records ACP prompt details, and reports additional stage failure conditions. ChangesHarness parameter propagation and diagnostics
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant runStage
participant SendPrompt
participant ServeProcess
runStage->>SendPrompt: submit migration prompt
SendPrompt-->>runStage: return PromptResult with stop reason and tool-call count
runStage->>ServeProcess: read captured Goose output when the stage fails
ServeProcess-->>runStage: return output snapshot
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@harness/internal/acp/session.go`:
- Around line 204-212: Update the prompt RPC error branch in the session request
flow to preserve and return the partially populated result instead of nil. Set
result.ToolCalls to turnCount before returning the error, including when
msg.Error contains data, so logPromptResult can emit diagnostics for partial
responses; keep the existing error messages unchanged.
In `@harness/internal/goose/lifecycle.go`:
- Around line 42-60: Update captureWriter and its snapshot flow to retain only a
bounded tail of child-process output, preventing unbounded growth in
captureWriter.Write. Define or reuse an appropriate size limit, discard older
bytes as new data arrives, and ensure the failure dump includes a clear
truncation marker whenever earlier output was removed.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a81c305e-3619-4834-960a-886d899aa4bf
📒 Files selected for processing (5)
harness/cmd/migration-harness/main.goharness/internal/acp/session.goharness/internal/config/config.goharness/internal/goose/lifecycle.goharness/internal/prompt/prompt.go
Signed-off-by: Dylan <dymurray@redhat.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Dylan Murray <dymurray@redhat.com>
Signed-off-by: Dylan <dymurray@redhat.com>
dymurray
force-pushed
the
harnessImprovements
branch
from
August 5, 2026 02:57
a8e9dfd to
4e723c0
Compare
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…stics) Signed-off-by: Dylan <dymurray@redhat.com>
djzager
added a commit
that referenced
this pull request
Aug 13, 2026
) ## Summary Three proposed ADRs and CONTEXT.md updates from a design grilling session covering parameter delivery, skill authoring boundaries, and execution controls. ### ADR 0009: Parameter Delivery via params.json Replaces per-parameter `KONVEYOR_PARAM_*` env vars with a single JSON file at `/run/konveyor/params.json`. Three-section shape: - `workflow` — workflow-level params (declared on AgentWorkflow, supplied on AgentWorkflowRun) - `agent` — agent-level params (declared on Agent, supplied on AgentRun), type-coerced - `execution` — resolved execution controls (maxTurns, maxCost, maxTokens, mode, sessionType) All prompt-composing text fields (Agent prompt, AgentRun instructions, AgentWorkflow guide and stage instructions) are rendered as Go templates by the controller with the resolved parameter map as the data context. Prior art: Ansible Playbook Bundles (`_apb_plan_parameters`), Ansible Runner (`extravars`), Tekton (`$(params.name)`). ### ADR 0010: Skill Content Boundary Refines ADR 0007's stage/domain skill taxonomy with a clear rule: > A skill contains knowledge and judgment criteria. It never contains execution control. **Allowed:** domain knowledge, approach guidance, quality criteria, output format, judgment calls. **Not allowed:** reading env vars, counting iterations, branching on exit codes, running infrastructure tools, git ops, filesystem discovery. Immediate changes: remove `MAX_FIX_ITERATIONS` from verify skill, remove env var reads, remove `git add && git commit` instructions. ### ADR 0011: Execution Controls, Mode, and Session Type on CRDs First-class CRD fields for execution concerns: | Category | Values | Purpose | |----------|--------|---------| | Execution limits | `maxTurns`, `maxCost`, `maxTokens` | Budget constraints — whichever limit is hit first triggers wind-down | | Mode | `auto` \| `approve` | Supervision policy — auto is headless, approve requires human via ACP tee | | Session type | `plan` \| `execute` | Runtime work pattern — plan uses native planning, execute does the work | CRD hierarchy (most specific wins): - Standalone: `AgentRun > Agent > system default` - Workflow: `AgentWorkflowRun > Stage > Agent > system default` Harness enforces limits by monitoring ACP `usage_update` notifications. Wind-down prompt at ~85-90% of any limit. Usage recorded on AgentRun status. ### CONTEXT.md Updated with new terms: Mode, Session Type, Execution Limits, Skill Content Boundary. Revised AgentRun and Harness entries to reflect params.json delivery and execution control semantics. ## Related - PR #99 (parameter injection to harness prompt — the starting point for this discussion) - ADR 0007 (harness as thin runner — refined by ADR 0010) - ADR 0008 (tee topology — mode and usage_update leverage) - Ian Bolton's HITL design on issues #55, #56 (mode and session type prior art) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Expanded guidance on execution controls, parameter resolution, precedence, and runtime configuration. * Documented standardized delivery of workflow, agent, and execution parameters. * Clarified the boundary between skill content and execution control. * Defined turn and cost limits, supervision modes, and session types. * Documented usage monitoring, cancellation, wind-down behavior, and execution reporting. * Added an unreleased feature entry covering these agent execution improvements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: David Zager <david.j.zager@gmail.com>
dymurray
pushed a commit
to djzager/agentic-controller
that referenced
this pull request
Aug 25, 2026
…onveyor#108) ## Summary Three proposed ADRs and CONTEXT.md updates from a design grilling session covering parameter delivery, skill authoring boundaries, and execution controls. ### ADR 0009: Parameter Delivery via params.json Replaces per-parameter `KONVEYOR_PARAM_*` env vars with a single JSON file at `/run/konveyor/params.json`. Three-section shape: - `workflow` — workflow-level params (declared on AgentWorkflow, supplied on AgentWorkflowRun) - `agent` — agent-level params (declared on Agent, supplied on AgentRun), type-coerced - `execution` — resolved execution controls (maxTurns, maxCost, maxTokens, mode, sessionType) All prompt-composing text fields (Agent prompt, AgentRun instructions, AgentWorkflow guide and stage instructions) are rendered as Go templates by the controller with the resolved parameter map as the data context. Prior art: Ansible Playbook Bundles (`_apb_plan_parameters`), Ansible Runner (`extravars`), Tekton (`$(params.name)`). ### ADR 0010: Skill Content Boundary Refines ADR 0007's stage/domain skill taxonomy with a clear rule: > A skill contains knowledge and judgment criteria. It never contains execution control. **Allowed:** domain knowledge, approach guidance, quality criteria, output format, judgment calls. **Not allowed:** reading env vars, counting iterations, branching on exit codes, running infrastructure tools, git ops, filesystem discovery. Immediate changes: remove `MAX_FIX_ITERATIONS` from verify skill, remove env var reads, remove `git add && git commit` instructions. ### ADR 0011: Execution Controls, Mode, and Session Type on CRDs First-class CRD fields for execution concerns: | Category | Values | Purpose | |----------|--------|---------| | Execution limits | `maxTurns`, `maxCost`, `maxTokens` | Budget constraints — whichever limit is hit first triggers wind-down | | Mode | `auto` \| `approve` | Supervision policy — auto is headless, approve requires human via ACP tee | | Session type | `plan` \| `execute` | Runtime work pattern — plan uses native planning, execute does the work | CRD hierarchy (most specific wins): - Standalone: `AgentRun > Agent > system default` - Workflow: `AgentWorkflowRun > Stage > Agent > system default` Harness enforces limits by monitoring ACP `usage_update` notifications. Wind-down prompt at ~85-90% of any limit. Usage recorded on AgentRun status. ### CONTEXT.md Updated with new terms: Mode, Session Type, Execution Limits, Skill Content Boundary. Revised AgentRun and Harness entries to reflect params.json delivery and execution control semantics. ## Related - PR konveyor#99 (parameter injection to harness prompt — the starting point for this discussion) - ADR 0007 (harness as thin runner — refined by ADR 0010) - ADR 0008 (tee topology — mode and usage_update leverage) - Ian Bolton's HITL design on issues konveyor#55, konveyor#56 (mode and session type prior art) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Expanded guidance on execution controls, parameter resolution, precedence, and runtime configuration. * Documented standardized delivery of workflow, agent, and execution parameters. * Clarified the boundary between skill content and execution control. * Defined turn and cost limits, supervision modes, and session types. * Documented usage monitoring, cancellation, wind-down behavior, and execution reporting. * Added an unreleased feature entry covering these agent execution improvements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: David Zager <david.j.zager@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds more detailed goose logging.
One thing this does which is completely hacky but for now I'm going to request we leave it which is to allow a user to set
KONVEYOR_PARAM_GCP_PROJECT_IDand have it respected for vertex provider until I figure out how to make it work properly.Summary by CodeRabbit