Restore the JetBrains plugin's Marketplace name - #430
Merged
Merged
Conversation
This change sets `projectName` to `kson-language`. This sets the zip filename (`kson-language-[version].zip`) as well as the on-disk plugins sub-directory. Using `kson-language` avoids overlap with a prior plugin using the `kson` name. Note that the plugin's display name comes from `<name>` in plugin.xml, so we can avoid setting it again.
Contributor
|
@holodorum FYI I added another commit to your PR. It's cherry-picked from PR #437. |
The IntelliJ Platform Gradle Plugin 2.x renamed `runPluginVerifier` to `verifyPlugin`. See https://plugins.jetbrains.com/docs/intellij/verifying-plugin-compatibility.html
Contributor
|
Also one more commit with some updated (another 2.x plugin change) verification instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading the 0.3.0 plugin is rejected:
The cause is the IntelliJ Platform Gradle Plugin v2 migration. Under v1,
pluginNameset the archive name; under v2,pluginConfiguration.namesets<name>inplugin.xml. SopluginName = KSONsilently overwrote the name andundid the earlier fix for this exact collision.
The same shift is why the release doc pointed at
KSON-[version].zipwhen the artifact is nowjetbrains-[version].zip. Both are corrected here, along with the missing-Prelease=trueon the documented build command — without it theplugin builds as
0.3.0-SNAPSHOT.