Repository navigation
Use pnpm link: for local packages and auto-update local lock files - #446
Merged
Merged
Conversation
Also: - adjust documentation to prefer gradle over pnpm - describe how to generate new lock files - rename npmInstall to npm_install to match gradle task name convention - use "hoisted" mode in LSP's nodeLinker (https://pnpm.io/settings/node-modules#nodelinker) to avoid re-installation with each run - regenerate the demo lockfiles (should have been done in previous commit)
By using the `link:` syntax for references to locally managed packages, we now use symlinks instead of hardlinks (the pnpm behavior for `file:` protocol). symlinks remain current as the local packages are changed where hardlinked files could lead to inconsistent results: added and deleted files were not propagated.
Executing `mocha` runs all the tests using `tsx` (see .mocharc.json). Before this change we were additionally running mocha against the transpiled `*.test.js` files. This was worth removing for two reasons: 1. We were running all the tests twice 2. Leftover .js files of the pattern `out/test/**/*.test.js` were being executed even if they weren't generated from existing typescript files. This happened sometimes when swapping branches without executing a `./gradlew clean`.
joeslice
force-pushed
the
use-pnpm-link
branch
from
September 27, 2026 19:48
57267e2 to
6a7e09c
Compare
holodorum
requested review from
holodorum
and removed request for
holodorum
September 27, 2026 20:05
holodorum
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
link:instead offile:protocol for local references to avoid stale file problems (old hardlinks vs new symlinks)pnpm-lock.yamlduring the build (--no-frozen-lockfile). Note this now matches Cargo, uv, pixi lockfile behavior (enforced at CI time).pnpm runwas executed.npmInstallgradle targets and prefersnpm_install(to matchnpm_...convention)./gradlew tooling:language-server-protocol:npm_installand./gradlew tooling:lsp-clients:checkwhen package.json changes and add a couple verification steps.*.test.jsfilesAlso this change: