Skip to content

fix: wait for cluster versions and remove retired NFS entry - #436

Merged
lixd merged 2 commits into
kubeclipper:masterfrom
lixd:fix/cluster-version-and-retired-nfs
Oct 22, 2026
Merged

lixd merged 2 commits into
kubeclipper:masterfrom
lixd:fix/cluster-version-and-retired-nfs

Conversation

@lixd

@lixd lixd commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix two remaining cluster configuration issues on top of the current official master:

  • Wait for component version metadata before initializing the cluster configuration step. Previously the wizard started an unawaited request when opening, so reaching configuration before that request completed could leave the version selections empty.
  • Remove the retired nfs-provisioner form schema and storage classification. The supported nfs-csi entry remains available.

Which issue(s) this PR fixes:

No linked issue.

Special notes for reviewers:

The diff contains four frontend source files only. It retains the Operation V2, operation node IP display, and terminal rendering fixes already on master; no backend OCI changes are included.

Validation:

  • All 8 existing unit-test suites passed (50 tests).
  • ESLint on all four changed files: no errors; five existing warnings in object.mapper.js.
  • A local delayed-response regression harness reproduced initialization before version data was available on the master baseline, and verified the fixed initialization waits for the version response. This was an isolated code-level check, not browser end-to-end validation.
  • Production webpack build and whitespace check passed.

Browser end-to-end regression was not performed in this run.

Does this PR introduced a user-facing change?

Fix empty version selections when entering cluster configuration before metadata has loaded, and remove the retired nfs-provisioner entry while retaining nfs-csi.

Additional documentation, usage docs, etc.:

None.

lixd added 2 commits October 22, 2026 11:10
Signed-off-by: lixd <xueduan.li@gmail.com>
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
lixd force-pushed the fix/cluster-version-and-retired-nfs branch from ade4e04 to e3bd65b Compare October 22, 2026 03:10
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.24%. Comparing base (c8ec5fe) to head (e3bd65b).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/object.mapper.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   47.30%   45.24%   -2.07%     
==========================================
  Files           7        8       +1     
  Lines         613      767     +154     
  Branches      176      224      +48     
==========================================
+ Hits          290      347      +57     
- Misses        250      333      +83     
- Partials       73       87      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lixd lixd left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lixd
lixd merged commit 97cd1fd into kubeclipper:master Oct 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant