Repository navigation
Conversation
Signed-off-by: lixd <xueduan.li@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 47.30% 55.65% +8.34%
==========================================
Files 7 12 +5
Lines 613 1008 +395
Branches 176 308 +132
==========================================
+ Hits 290 561 +271
- Misses 250 359 +109
- Partials 73 88 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: lixd <xueduan.li@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
A failed task can have no shell output, and a log request can fail after receiving only part of its content. The operation log dialog now keeps the failure cause visible and supports reading the remaining output.
This builds on the log-read error handling already merged in #437.
Which issue(s) this PR fixes:
No linked issue.
Special notes for reviewers:
Validation:
Companion backend PR: kubeclipper/kubeclipper#1022
The companion backend change adds service-control diagnostics to the existing task log API; this PR introduces no API schema change.
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
None.