Skip eviction in case when the Node is NotReady#2002
Merged
Conversation
kubermatic-bot
added
kind/bug
kubermatic-bot
added
the
do-not-merge/work-in-progress
Contributor
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
kubermatic-bot
added
the
lifecycle/stale
Contributor
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
kubermatic-bot
added
lifecycle/rotten
kron4eg
removed
the
lifecycle/rotten
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
kron4eg
force-pushed
the
not-ready-eviction
branch
from
db2723b to
e6d5724
Compare
kubermatic-bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
kubermatic-bot
added
size/M
Contributor
|
LGTM label has been added. DetailsGit tree hash: 15c70b08853ea6cbdf307c4310143b774c8f7838 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the Node is in NotReady condition, it's useless to try to drain it, causes endless loop of drain retrying of half-dead Node.
Which issue(s) this PR fixes:
Fixes #1586
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: