Repository navigation
fix(e2e): seed marketplace status cards with required config field - #24435
Conversation
The marketplace-status-cards spec added in #24434 seeds kubestellar-cluster-admin-cards localStorage entries without a config field. loadDashboardCardsFromStorage validates every stored entry with isValidDashboardCard, which requires config to be a plain object; the seeded array fails validation, storage is cleared, and the default cluster-admin card set renders instead — so every [data-card-type="<type>_status"] locator times out. All 7 tests in the spec fail deterministically on main shard 2. Adding config: {} to each seeded card makes the entries pass validation so the cards under test actually mount. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Fixes the main-branch Playwright shard-2 failure introduced by #24434.
Symptom: all 7 tests in
web/e2e/marketplace-status-cards.spec.tsfail on main (run 39129149547, head 1f1b039) withexpect(locator).toBeVisible() failed … element(s) not foundfor every[data-card-type="<type>_status"]locator.Root cause: the spec seeds
kubestellar-cluster-admin-cardslocalStorage entries without aconfigfield.loadDashboardCardsFromStorage(web/src/lib/dashboards/dashboardCardStorage.ts) validates each stored entry withisValidDashboardCard, which requiresconfigto be a plain object. The seeded array fails validation, storage is cleared, and the default cluster-admin card set renders instead — the cards under test never mount. Deterministic, not a flake.Fix: add
config: {}to each seeded card so the entries pass validation.(The
oauth-flow.spec.tsfailure in the same run is a separate known flake and is not addressed here.)— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88