Skip to content

fix(e2e): seed marketplace status cards with required config field - #24435

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-marketplace-cards-e2e-config
Oct 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-marketplace-cards-e2e-config

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Fixes the main-branch Playwright shard-2 failure introduced by #24434.

Symptom: all 7 tests in web/e2e/marketplace-status-cards.spec.ts fail on main (run 39129149547, head 1f1b039) with expect(locator).toBeVisible() failed … element(s) not found for every [data-card-type="<type>_status"] locator.

Root cause: the spec seeds kubestellar-cluster-admin-cards localStorage entries without a config field. loadDashboardCardsFromStorage (web/src/lib/dashboards/dashboardCardStorage.ts) validates each stored entry with isValidDashboardCard, which requires config to be a plain object. The seeded array fails validation, storage is cleared, and the default cluster-admin card set renders instead — the cards under test never mount. Deterministic, not a flake.

Fix: add config: {} to each seeded card so the entries pass validation.

(The oauth-flow.spec.ts failure in the same run is a separate known flake and is not addressed here.)

— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88

The marketplace-status-cards spec added in #24434 seeds
kubestellar-cluster-admin-cards localStorage entries without a config
field. loadDashboardCardsFromStorage validates every stored entry with
isValidDashboardCard, which requires config to be a plain object; the
seeded array fails validation, storage is cleared, and the default
cluster-admin card set renders instead — so every
[data-card-type="<type>_status"] locator times out. All 7 tests in the
spec fail deterministically on main shard 2.

Adding config: {} to each seeded card makes the entries pass validation
so the cards under test actually mount.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 18, 2026
@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit bedf559
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6ad4ea1556248052be6d936d
😎 Deploy Preview https://deploy-preview-24435.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Oct 18, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-kubestellar-console-4vkt | SHA: 53bc970

— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 8026ad0 into main Oct 18, 2026
44 of 45 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-marketplace-cards-e2e-config branch October 18, 2026 16:14
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#24435bedf559` sha256:75a41fa8d10c66847a6be13612dca2bf320438d8d6cc3e6814755c7a301f3301 — download from the dashboard or `hivectl review evidence #24435`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 8026ad0adb7787427357f9b5761d477170dce339.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 8026ad0adb7787427357f9b5761d477170dce339
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/39144124584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants