Repository navigation
fix: use semantic status colors and improve contrast per Auto-QA findings - #24449
Conversation
…ings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/S
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed against main. The conversion is correct: text-status-success/-warning/-error are the semantic utilities defined in web/tailwind.config.js ("Semantic status colors — use for health indicators, alerts, badges"), and keeping the raw bg-green-500/20-style backgrounds while converting only the text color is the documented, established idiom — the config comment notes opacity modifiers don't work with var() values, and the same mix (bg-green-500/20 text-status-success) already appears in web/src/components/cards/kubevela_status/helpers.tsx, backstage_status/index.tsx, and cloudevents_status/CloudEventsStatus.tsx. Looks correct to me.
One small leftover in the same file: web/src/components/cards/cluster-resource-tree/NamespaceTreeNode.tsx:95 — the pods-section issue badge keeps badgeColor="bg-red-500/20 text-red-400" while the identical namespace-level badge at line 67 was converted to text-status-error. Not a defect (it renders the same today), just an inconsistency this PR's stated goal would naturally include; fine to fold into a follow-up if the Auto-QA finding list didn't cite it.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
hivecommons-hive
Bot
added
stage/060-reviewed
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Closes #24442
Refs #24441 — no code change here: its remaining findings are inline chart/preview hex colors already addressed by #24444/#24447; anything left needs a fresh Auto-QA run to confirm.
Follows up on #24444 which partially addressed these; this fixes the remaining cited #24442 findings (semantic status text colors in ClusterHealthStatsGrid and NamespaceTreeNode).
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@clubanderson