Repository navigation
fix: polyfill Promise.withResolvers for jsdom 30 on Node 20 prow image - #7447
Conversation
jsdom 30's Document-impl.js close() calls the ES2024 Promise.withResolvers (native only in Node >= 22). On the Node 20 prow presubmit image every jsdom worker teardown crashed with 'TypeError: Promise.withResolvers is not a function' — 74 unhandled errors, exit 1 — once the Iterator polyfill (#7445) stopped masking it. Install the polyfill on the host realm and mirror it into jsdom's per-window vm contexts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellar-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubestellar-prow
Bot
added
the
size/M
kubestellar-prow
Bot
added
the
needs-ok-to-test
github-actions
Bot
added
documentation
|
Hi @hivecommons-hive[bot]. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hivecommons-hive
Bot
added
author/hive
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
Closes #7446
pull-kubestellar-docs-testfails on every PR: jsdom 30'sDocument-impl.js close()calls the ES2024Promise.withResolvers(native only in Node >= 22), so on the Node 20 prow image every jsdom worker teardown crashes — 1298/1298 tests pass but 74 unhandled errors force exit 1 (prow run 2111781981573353472 on #7440). The Iterator crash fixed in #7445 happened earlier in window creation and masked this one.Fix:
scripts/node-iterator-polyfill.cjsnow also installsPromise.withResolverson the host realm and mirrors it into jsdom's per-window vm contexts (same approach as the Iterator mirroring).— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88