Bump toml to 1.1.6 (consolidate #251) - #258
Merged
Merged
Conversation
Rolls Dependabot #251 onto a gated branch so the version bump, NOTES entry and man-page regeneration it skips are done. Lockfile-only: the "1.1" caret spec already admits 1.1.6, and nothing else moves. The only code change in 1.1.6 is an ownership refactor in de/parser/document.rs::finish_table, which toml::from_str reaches for every table header. Both of its branches were exercised live against a throwaway config: a [custom_theme] table applies, and a duplicated header still reports the correct span. Assisted-By: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates Dependabot #251 (
toml1.1.5 -> 1.1.6) onto a gated branch, following the standing pattern (#167/v0.6.3 through #228/v0.11.8). Dependabot skips the version bump, NOTES entry and man regen; this does them.What changes
"1.1"caret spec already admits 1.1.6, so neither manifest widens. TheCargo.lockdiff is exactly thetomlentry plus theretch-cliversion, with no transitive movement.retch-cli-> 0.17.16.retch-sysinfounchanged at 0.1.76 (it does not depend ontoml).docs/retch.1regenerated (version footer only); NOTES.md header + entry.Why it is safe — established from the source, not from a green build
Both
.cratefiles were downloaded (sha256 matching the lockfile checksums) and compared file by file. The whole code change is one function,src/de/parser/document.rs::finish_table, and unlike v0.11.4's 1.1.5 bump it is reachable:toml::from_str(retch's only call site,src/config.rs) runs it for every[table]header. It is an ownership refactor only — the header key is moved into the parent table instead of cloned, andkey_spanis computed before that move rather than inside the duplicate-key error branch. The crate's own manifest changes only its version line (MSRV still 1.85).toml_edit, where the upstream changelog's other perf work landed, is not in retch's graph.Test plan
just prpasses (branch, version, NOTES header, man page, Cargo.lock, fmt + clippy incl.--features graphics, tests, audit)cargo test --workspace: 322 tests green (95 + 16 + 210 + 1)Cargo.lockdiff is thetomlentry +retch-cliversion onlyfinish_tablebranches exercised live with a throwawayXDG_CONFIG_HOME: a[custom_theme]table withlabel_color = "#ff0000"renders the label asESC[38;2;255;0;0m; a duplicated[custom_theme]header fails withduplicate keyat line 4, column 2docs/retch.mdchecked — none names the dependency, so none changesCloses #251 once merged (Dependabot auto-closes after it sees the change land).
🤖 Generated with Claude Code