Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
geruh
force-pushed
the
codex/shared-deletion-scan-statistics
branch
from
October 3, 2026 01:32
1375ece to
b5765a2
Compare
geruh
marked this pull request as ready for review
October 3, 2026 01:32
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
lance-gatekeeper
Bot
removed
the
K-approved
lance-gatekeeper
Bot
added
the
K-approved
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that scans retaining its deleted rows could report the visible row count as exact even though the scan correctly emits the physical rows.
For example, a 60-row dataset with 5 deletions emits 60 rows in this mode but previously reported
Exact(55).This fixes the statistics in both scan plans by reporting the physical row count when it is trustworthy, and leaving the count unknown otherwise.
Validation:
cargo test --locked --profile ci -p lance --lib io::exec::scan::tests::, 13 passed.-D warnings, formatting, diff checks, and pre-commit hooks passed. Clippy used the repositoryciprofile.