fix(datafusion): preserve regexp_match null checks - #9698
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The shared filter-planner fix addresses the incorrect row selection in #9695. Explicit null checks and comparisons retain the regex result’s nullable list semantics, while direct boolean filters retain their existing coercion.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit
regexp_match(...) IS NOT NULLfilter becameIsNotNull(IsNotNull(regexp_match(...))), selecting every row, including NULL inputs. The correspondingIS NULLfilter selected no rows. Filter coercion also rewrote regex results inside comparisons.Restrict coercion to the filter root and AND/OR/NOT operands. Explicit null checks and comparisons now retain DataFusion's nullable list result, while bare regex filters keep their existing behavior. Extend the planner tests with matching, nonmatching, and NULL rows, boolean combinations, and value-context preservation.
Validation:
cargo test --locked --profile ci -p lance-datafusion: 198 unit tests and five doctests passed; three existing doctests were ignored.cargo fmt --allpassed.cargo clippy --locked --profile ci --all --tests --benches -- -D warningspassed.Fixes #9695