Repository navigation
Declare reviewed ThreadDesk MCP read-only tools for dynamic discovery - #85
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80df6eff55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _tool["annotations"] = { | ||
| "readOnlyHint": True, | ||
| "destructiveHint": False, | ||
| "openWorldHint": False, |
There was a problem hiding this comment.
Every stdio initialization still advertises protocolVersion: "2024-11-05" in src/threaddesk/ui/mcp_stdio.py:33-40, but tool annotations were introduced only in MCP 2025-03-26, as confirmed by the MCP maintainers. Consequently, a version-aware client connected under the advertised contract may discard or reject these fields, so the dynamic proxy this change targets cannot reliably discover them; negotiate at least 2025-03-26 before emitting the annotations.
Useful? React with 👍 / 👎.
| "list_threads", | ||
| "get_thread", | ||
| "current_thread", | ||
| "list_snapshots", | ||
| "list_gnom_jobs", | ||
| "check_gate", |
There was a problem hiding this comment.
For a JSON workspace containing an unanchored legacy thread, or one changed by an older writer, calls such as list_threads, get_thread, current_thread, get_reentry, list_snapshots, and check_gate with an ID reach JsonStore.get_thread(), which persists a revision anchor and can rewrite the thread while incrementing its revision (json_store.py:472-499). That contradicts the MCP definition that readOnlyHint: true means the tool does not modify its environment (official schema), allowing the new read proxy to cause persistent workspace changes; withhold the hint for these paths or perform the repair before exposing them as read-only.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Adds read-only annotations to audited non-mutating ThreadDesk MCP tools, with regression checks. Write, context-changing and disk-writing tools remain unannotated. No original operations or input schemas are changed. This supports an opt-in KiraBridge dynamic read proxy. Source code has not been installed on a user device. Tests are committed but full repository/macOS CI has not been executed here.