Repository navigation
fix(tracing): nest subagent turns under their spawn_agent call - #109
Merged
Merged
Conversation
Record the spawn call id for each subagent thread and parent the child rollout on the matching spawn_agent tool observation, falling back to the turn root when no match is found. Also recognize the item_completed SubAgentActivity layout that Codex 0.157.x writes for subagent starts.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subagent turns currently nest under the parent turn root, so in Langfuse they show up as siblings of the
spawn_agentcall that started them instead of under it. This parents each subagent rollout on its matchingspawn_agenttool observation.Changes
parseSessionrecords the spawn call id for each subagent thread (subagentSpawnCallIds), fromspawn_agenttool output,collab_agent_spawn_end, andsub_agent_activity.item_completed/SubAgentActivitylayout that Codex 0.157.x writes for subagent starts.emitTurnparents the child rollout on the matchingspawn_agentobservation, falling back to the turn root when there's no match. So the old behavior is the fallback, not a regression.Testing
pnpm lintandpnpm testpass (121 tests).item_completedlayout. Existing parse tests now assert the thread to call-id mapping.spawn_agentspan, in both standalone and attached (external parent) mode.