Repository navigation
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the selected query or document purpose for
gemini-embedding-001through the Google native embedding route.The plugin sends
RETRIEVAL_QUERYorRETRIEVAL_DOCUMENTwithout changing the input text.The existing retrieval prefixes for
gemini-embedding-2-previewstay unchanged.Deployment prerequisite
Do not merge this PR until production Tokener.ai routes
gemini-embedding-001through the native Google Gemini upstream.The Google OpenAI-compatible endpoint rejects
task_type.Merging plugin changes into this repository's
mainbranch triggers the Marketplace upload workflow.Release Notes
Gemini embedding queries and documents retain their selected retrieval purpose.
Change Type
Testing
The existing plugin test suite passed with 656 tests and three expected failures.
The real Dify invocation through Gateway and pinned LiteLLM reached Google with the corresponding
taskTypefor both purposes.Both Google calls returned vectors with 3,072 dimensions.
Production deployment and Marketplace publication remain unverified.
Version
Bump the plugin manifest from
0.4.2to0.4.3.