Repository navigation
fix(uploads): clean up multipart temporary files - #850
Merged
Merged
Conversation
fatelei
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Plugin and bundle uploads that spill to disk leave
multipart-*files behind because tracing replaces the request andnet/httponly cleans the original request.Defer multipart form cleanup in both upload handlers, covering successful uploads and early error returns. Opened upload files close before cleanup, and cleanup failures are logged with the request context.
Fixes #849
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Regression tests use the actual tracing middleware and upload controllers, lower Gin's memory threshold, and verify that multipart files exist during processing and are removed after the handler returns. They cover size-limit rejection, missing fields or tenant IDs, non-multipart requests, invalid archives, and an accepted bundle.
Validation:
go test -count=1 -v -timeout=60s ./internal/server/controllers ./pkg/utils/logandgit diff --check.The multipart cleanup assertions failed before the fix and pass with it.