Repository navigation
Conversation
Preserve the reranking model regression tests and the repository-backed app query fixture from main.
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-11-03 03:39:56.026937339 +0000
+++ /tmp/pyrefly_pr.txt 2026-11-03 03:39:43.466841659 +0000
@@ -5665,9 +5665,9 @@
ERROR Object of class `NoneType` has no attribute `storage_key` [missing-attribute]
--> tests/unit_tests/factories/file_factory/test_builders.py:196:12
ERROR Object of class `Dataset` has no attribute `embedding_available` [missing-attribute]
- --> tests/unit_tests/fields/test_dataset_fields.py:228:5
+ --> tests/unit_tests/fields/test_dataset_fields.py:236:5
ERROR Argument `str` is not assignable to parameter `indexing_status` with type `IndexingStatus | SQLCoreOperations[IndexingStatus]` in function `models.dataset.Document.__init__` [bad-argument-type]
- --> tests/unit_tests/fields/test_dataset_fields.py:299:25
+ --> tests/unit_tests/fields/test_dataset_fields.py:307:25
ERROR Cannot set item in `OrderedDict[str, bool | list[str] | str]` [unsupported-operation]
--> tests/unit_tests/fields/test_workflow_draft_variable_fields.py:142:47
ERROR Object of class `Subscription` has no attribute `_start_if_needed` [missing-attribute]
|
Pyrefly Type Coverage
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43853 +/- ##
===========================================
+ Coverage 68.81% 89.80% +20.98%
===========================================
Files 6103 6240 +137
Lines 368940 391005 +22065
Branches 77825 79312 +1487
===========================================
+ Hits 253897 351123 +97226
+ Misses 112233 33782 -78451
- Partials 2810 6100 +3290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Updated against main in |
Summary
Fixes #43847. Dataset cards now reflect both embedding and reranking model availability, so a missing or disabled required reranker produces the Unavailable badge and corresponding card/menu state. Responses expose
reranking_availableusing active models in the current workspace.Weighted-score hybrid search, disabled reranking, economy indexing, and external knowledge bases do not require a reranker lookup. Normalize legacy provider IDs on reads without rewriting stored retrieval configuration; incomplete configuration is unavailable.
Synchronize with main at
b531dcbe, preserving current dataset visibility, response contracts, card interactions, and tag management. Extend the existing stored-configuration regression to cover an empty provider name.Validation
git diff --check: passed.24e92355: passed. Full backendmake lintalso passed.AI-assisted implementation and validation with Codex.