Repository navigation
Conversation
Assert observable outcomes instead of internal call sequences across telemetry dispatch, mail sending, queue routing, and OpenAPI export tests, per langgenius#41418.
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45298 +/- ##
==========================================
- Coverage 89.77% 89.77% -0.01%
==========================================
Files 6239 6239
Lines 390924 390924
Branches 79291 79291
==========================================
- Hits 350950 350946 -4
- Misses 33875 33877 +2
- Partials 6099 6101 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI triage for the current head ( This comes from the wall-clock-derived parametrization in No unrelated test change is needed in this PR. I could not rerun the upstream job with my fork's Actions permissions; a maintainer rerun (or a fresh run after #45243 merges) should verify this head once the collection flake is addressed. This assessment is from CI logs and source inspection; I have not claimed a local Dify test run. Update (Nov 2, 2026): Upstream #45308 has since merged and its change to |
Merge upstream main at 8d812b9 to include the stable xdist parameter IDs from langgenius#45308. Preserve the existing four-file test-only scope for langgenius#41418. Validated the merged tree with 106 focused tests, 10 xdist regression tests, full lint and type-check. AI-assisted with Codex.
Validate schema roots together instead of recursively rechecking each descendant. Preserve nested required-field, reference and discriminator checks, with four negative regression cases. Give the aggregate five-document check a 60-second budget under coverage. The previous head fails under the CI 20-second limit. The updated four-module suite passes 110 tests with the same global timeout; full lint and type-check pass. AI-assisted with Codex.
Summary
EnterpriseMetricHandler.handle().8d812b938af6, including the stable xdist parameter IDs merged in fix(api): pass lint, type check and unit tests on the new dev dependencies #45308.Refs #41418. This is a selected four-module slice of the broader cleanup.
Screenshots
N/A (test-only change).
Validation
Executed locally on macOS / Python 3.13.11 against the tree committed as
67710432275c8d3e1fb42664bacdd8b65998eae4:uv run --project api --python 3.13 --frozen --dev pytest api/tests/unit_tests/tasks/test_generate_summary_index_task.py api/tests/unit_tests/tasks/test_mail_inner_task.py api/tests/unit_tests/enterprise/telemetry/test_metric_handler.py api/tests/unit_tests/dev/test_generate_swagger_specs.py --timeout 20 --durations=5 -q— 110 passed in 189.23s. The aggregate OpenAPI contract test took 13.01s in this run.UV_PYTHON=3.13 UV_FROZEN=1 make lint— passed; no unrelated file changes; 82 import contracts kept.UV_PYTHON=3.13 UV_FROZEN=1 make type-check— passed.UV_PYTHON=3.13 UV_NO_SYNC=1to reuse the environment already synchronized from the committed lockfile.git diff --check upstream/main...HEAD— clean; the PR still changes only its original four test files.Before the follow-up, the aggregate OpenAPI check reproducibly exceeded the CI 20-second limit locally and in upstream CI on head
6f49055e45(that unit shard otherwise passed 12,726 tests). The follow-up removes repeated recursive validation and budgets the remaining real work explicitly. The console export alone is about 4.4 MB with 2,113 component schemas; the test checks all five exports. Nested malformed-schema, missing-required-property, dangling-reference, and discriminator failures remain covered.Upstream checks on
6771043227have completed: 35 successful, 14 skipped, no failed or pending checks (verified Nov 3, 2026), including API unit/controller/integration jobs, Python style, and Codecov. GitHub reports MERGEABLE; maintainer review is still required.The full repository test suite and Docker-backed integration suites were not run locally for this test-only PR. No production code, generated contracts, dependency, or lockfile changes are included.
Checklist
make lint && make type-check(backend), with the environment recorded above.vp stagedis N/A (no frontend changes).From Codex