Repository navigation
fix: add online_drive to DataSourceType on lts/1.13.x - #45368
Merged
wylswz merged 1 commit intoNov 3, 2026
Merged
Conversation
(cherry picked from commit 993a301)
Contributor
Pyrefly Type Coverage
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-11-03 02:54:40.181703917 +0000
+++ /tmp/pyrefly_pr.txt 2026-11-03 02:54:33.661746925 +0000
@@ -2853,7 +2853,7 @@
ERROR Cannot index into `str` [bad-index]
--> tests/unit_tests/core/app/apps/pipeline/test_pipeline_generate_response_converter.py:111:12
ERROR Class `PipelineRunner` has no class attribute `call_args` [missing-attribute]
- --> tests/unit_tests/core/app/apps/pipeline/test_pipeline_generator.py:340:12
+ --> tests/unit_tests/core/app/apps/pipeline/test_pipeline_generator.py:341:12
ERROR Argument `SimpleNamespace` is not assignable to parameter `application_generate_entity` with type `RagPipelineGenerateEntity` in function `core.app.apps.pipeline.pipeline_runner.PipelineRunner.__init__` [bad-argument-type]
--> tests/unit_tests/core/app/apps/pipeline/test_pipeline_runner.py:65:37
ERROR Argument `SimpleNamespace` is not assignable to parameter `application_generate_entity` with type `RagPipelineGenerateEntity` in function `core.app.apps.pipeline.pipeline_runner.PipelineRunner.__init__` [bad-argument-type]
|
41tair
approved these changes
Nov 3, 2026
wylswz
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #34440 to LTS 1.13.x.
Adding files from an
online_drivedatasource (e.g. SharePoint, OneDrive) in a published Knowledge Pipeline fails with a 500, becauseDataSourceTypehas noONLINE_DRIVEmember and thedocuments.data_source_typeenum check rejects the insert:The fix was cherry-picked to the
hotfix/1.13.3-fix*branches but never reachedlts/1.13.x. No migration is needed; the column isVARCHARand the enum is validated in the application layer.Source: #34440
Source commit: 993a301
Verification
lts/1.13.x.pytest tests/unit_tests/core/app/apps/pipeline/test_pipeline_generator.py: 20 passed. Without the enum change, the new test fails with the error above.ruff checkandruff format --checkpass on the changed files.From Amp