Repository navigation
Conversation
…tial baseline (lanl#1371) Four rows from the first scheduled nightly on main after 238d4d3 (run 40899240805): three now PASS and BIOMD0000000827 is SKIP. Only these rows are replaced, because that run predates the jacobian_values check the committed baseline holds; source.rows_from names where they came from.
Collaborator
|
Superseded by #1423, which records these four klu_vs_dense rows (and the rest of the baseline) from nightly run 41076909610 with the same outcomes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1371.
What this records
These are the four
klu_vs_denserows ofparity_checks/nightly/baselines/differential.jsonthat #1295's fix (238d4d3) changed, taken from the first scheduled nightly on main after it: run 40899240805, at c0877fa.MODEL1912090001|klu_vs_denseMODEL2002030001|klu_vs_denseCV_ERR_FAILURE)MODEL7743528808|klu_vs_denseBIOMD0000000827|klu_vs_denseCV_CONV_FAILURE)The run's own diff against the committed baseline reads no regressions. These are its 3 improvements and its 1 change between failing states.
Only these four rows, not the whole file
The issue's recipe is to copy the run's
verdicts.jsonover the baseline. That would be wrong here.jacobian_valuescheck: 11 checks, 14,883 cases.jacobian_valuesrows.jacobian_values, exactly these four rows changed outcome.So the file is #1308's run with these four rows replaced. It is written with
verdicts.dump_verdicts, so the diff is one line per row.source.rows_fromnames the run, sha, CPU and cases they came from.Checked
verdicts.py diff, tonight's run against the patched baseline: 0 improved (3 against main's baseline). Every remaining difference isjacobian_values: 1,279 regressed and 74 dropped, which are rows tonight's run did not run.ci/changelog.py requiredpasses for a baseline-only change, andpre-commitis clean.Not changed
MODEL1006230034|klu_vs_denseis still EXCEPTION on the Linux runner, though klu: step each colored FD column on the error weights' scale (#1254) #1295 measured it at 3.2e-6 on macOS arm64. It stays as recorded.BIOMD0000000338|klu_vs_denseis Nightly parity: regressions detected #1355's flaky row, already inflaky.json. Unchanged.A baseline-only PR does not run the nightly:
pull_request.pathsexcludesparity_checks/nightly/baselines/**. The next scheduled nightly is the one that should read no change on these rows.