Skip to content

nightly: record the klu_vs_dense rows #1295 fixed in the differential baseline (#1371) - #1392

Closed
Montana wants to merge 1 commit into
lanl:mainfrom
Montana:nightly/1371-rebaseline-differential
Closed

Montana wants to merge 1 commit into
lanl:mainfrom
Montana:nightly/1371-rebaseline-differential

Conversation

@Montana

@Montana Montana commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Closes #1371.

What this records

These are the four klu_vs_dense rows of parity_checks/nightly/baselines/differential.json that #1295's fix (238d4d3) changed, taken from the first scheduled nightly on main after it: run 40899240805, at c0877fa.

case baseline tonight
MODEL1912090001|klu_vs_dense DIFF, 3.11e-2 of the peak PASS, 1.47e-4 (bound 2.0e-3)
MODEL2002030001|klu_vs_dense EXCEPTION (CV_ERR_FAILURE) PASS, 1.65e-6 (bound 1.0e-3)
MODEL7743528808|klu_vs_dense DIFF, 2.09e-3 (bound 2.1e-3) PASS, 0.0
BIOMD0000000827|klu_vs_dense EXCEPTION (CV_CONV_FAILURE) SKIP: no reference (the base moves 0.25 at a tenfold tighter tolerance)

The run's own diff against the committed baseline reads no regressions. These are its 3 improvements and its 1 change between failing states.

Only these four rows, not the whole file

The issue's recipe is to copy the run's verdicts.json over the baseline. That would be wrong here.

So the file is #1308's run with these four rows replaced. It is written with verdicts.dump_verdicts, so the diff is one line per row. source.rows_from names the run, sha, CPU and cases they came from.

Checked

  • verdicts.py diff, tonight's run against the patched baseline: 0 improved (3 against main's baseline). Every remaining difference is jacobian_values: 1,279 regressed and 74 dropped, which are rows tonight's run did not run.
  • The recorded rows are not on a knife edge: the closest is 14× under its bound.
  • ci/changelog.py required passes for a baseline-only change, and pre-commit is clean.

Not changed

A baseline-only PR does not run the nightly: pull_request.paths excludes parity_checks/nightly/baselines/**. The next scheduled nightly is the one that should read no change on these rows.

…tial baseline (lanl#1371)

Four rows from the first scheduled nightly on main after 238d4d3 (run
40899240805): three now PASS and BIOMD0000000827 is SKIP. Only these rows
are replaced, because that run predates the jacobian_values check the
committed baseline holds; source.rows_from names where they came from.
@wshlavacek

Copy link
Copy Markdown
Collaborator

Superseded by #1423, which records these four klu_vs_dense rows (and the rest of the baseline) from nightly run 41076909610 with the same outcomes.

@wshlavacek wshlavacek closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly: re-baseline differential klu_vs_dense after #1295 (four BioModels now pass)

2 participants