Skip to content

nightly: BIOMD0000000338's klu_vs_dense is not flaky; drop it from flaky.json - #1393

Merged
wshlavacek merged 1 commit into
mainfrom
nightly/unflake-biomd338
Oct 29, 2026
Merged

wshlavacek merged 1 commit into
mainfrom
nightly/unflake-biomd338

Conversation

@wshlavacek

Copy link
Copy Markdown
Collaborator

Removes BIOMD0000000338|klu_vs_dense from parity_checks/nightly/flaky.json. #1338 added it, saying the dense reference depends on the runner's CPU. On Linux it does not. The full measurements are in this comment on #1304.

Why it is not flaky

#1338's evidence was a PASS run on an EPYC 9V45 and an EXCEPTION run on a Xeon 8370C. Those two runs fall on either side of #1302. Across all eight runs on either side, the outcome follows the commit, and the same CPU model gives both outcomes:

runs CPUs klu_vs_dense
before #1302 (main at b543f7b) 3 EPYC 9V45, 7763, 9V74 PASS
after #1302 (main at aedadd8 or later) 5 EPYC 9V74, 7763, Xeon 8370C EXCEPTION, CV_CONV_FAILURE at t = 0.72

#1321's per-run timeout is ruled out. The passing EPYC 9V74 run already had it, and the code klu_vs_dense runs through is identical there and in a failing run on the same CPU model.

Why remove the entry

Checked

  • Replayed verdicts.py diff with and without the entry:
  • parity_checks/tests/test_nightly_verdicts.py: 75 passed, including the committed-file format check, which needs every listed suite to keep at least one case. differential had only this one, so its key goes too.
  • flaky.json is outside the nightly's pull-request path filter, so this pull request does not re-run the sweep.

Refs #1304. That issue stays open: the dense quotient's failure on Linux after #1302 is still unexplained.

…aky.json (#1304)

#1338 listed the case as depending on the runner's CPU. Its PASS run and
its EXCEPTION run fall on either side of #1302, and across all eight runs
on either side the outcome follows the commit: PASS on EPYC 9V45, 7763
and 9V74 before #1302, EXCEPTION on EPYC 9V74, 7763 and Xeon 8370C after.
The measurements are on #1304.

The committed baseline records the case as EXCEPTION (#1367), and that is
what keeps it from alerting. The entry only gave the wrong cause. Once a
fix brings the case back to PASS and the baseline follows, it would also
keep a later flip from alerting.
@wshlavacek
wshlavacek merged commit 22018fa into main Oct 29, 2026
14 checks passed
@wshlavacek
wshlavacek deleted the nightly/unflake-biomd338 branch October 29, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant