Repository navigation
nightly: BIOMD0000000338's klu_vs_dense is not flaky; drop it from flaky.json - #1393
Merged
Merged
Conversation
…aky.json (#1304) #1338 listed the case as depending on the runner's CPU. Its PASS run and its EXCEPTION run fall on either side of #1302, and across all eight runs on either side the outcome follows the commit: PASS on EPYC 9V45, 7763 and 9V74 before #1302, EXCEPTION on EPYC 9V74, 7763 and Xeon 8370C after. The measurements are on #1304. The committed baseline records the case as EXCEPTION (#1367), and that is what keeps it from alerting. The entry only gave the wrong cause. Once a fix brings the case back to PASS and the baseline follows, it would also keep a later flip from alerting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
BIOMD0000000338|klu_vs_densefromparity_checks/nightly/flaky.json. #1338 added it, saying the dense reference depends on the runner's CPU. On Linux it does not. The full measurements are in this comment on #1304.Why it is not flaky
#1338's evidence was a PASS run on an EPYC 9V45 and an EXCEPTION run on a Xeon 8370C. Those two runs fall on either side of #1302. Across all eight runs on either side, the outcome follows the commit, and the same CPU model gives both outcomes:
klu_vs_denseCV_CONV_FAILUREat t = 0.72#1321's per-run timeout is ruled out. The passing EPYC 9V74 run already had it, and the code
klu_vs_denseruns through is identical there and in a failing run on the same CPU model.Why remove the entry
Checked
verdicts.py diffwith and without the entry:parity_checks/tests/test_nightly_verdicts.py: 75 passed, including the committed-file format check, which needs every listed suite to keep at least one case.differentialhad only this one, so its key goes too.flaky.jsonis outside the nightly's pull-request path filter, so this pull request does not re-run the sweep.Refs #1304. That issue stays open: the dense quotient's failure on Linux after #1302 is still unexplained.