Repository navigation
nightly: pin reference-data-v3, recorded with the SSA screen's fix - #1397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
reference-data-v3so the nightly replays from it. It's the recording that #1325 needs: #1325 makes the RoadRunner SSA screen keep a slow model's reference on a recording, as #1293 did for rr_ode (#1290).What was recorded
The record-mode run 40899940910, at
e4255465(the merge of #1325), recorded v3. Every suite passed and the night had no regressions. No entry was left out by the license gate.The run's publish job was refused (HTTP 403) creating the release's tag at
e4255465, on its first attempt and on a rerun. So reference-data-v3 was published by hand from that run's own assets, with the same title, notes and assets. Its tag is on main's head when it was published (05ee8039). This manifest was built byreference_archive.py manifestwith the job's own arguments. That script is the same ate4255465and on main. Each asset's sha256 here matches the digest GitHub reports for the published file. #1396 changes the publish job to tag the default branch's head, and explains the 403.rr_ssa. The recording timed out 14 models before their reference (v2: 19). No model joined that list. The five that left it are the five v2 added:
MODEL1102210001 is the one that passes on some nights. Under v2, any replay after a live night that passed it alerted. BIOMD0000000530, which replayed as
archive_unreplayableunder v2, has its whole ladder recorded and PASSes (vacuous_lowcount). Six rows ran past the 120 s cap and still saved their reference: BIOMD0000000558, BIOMD0000000767, MODEL1112100000, MODEL1909300003, MODEL2002030001 and MODEL8459127548. They stay TIMEOUT, as on a live night.rr_ode. Only the two giants, MODEL1504130000 and MODEL1603150001, timed out before their reference, as in v2. They don't alert: their baseline is TIMEOUT.
bng_nf. One case that's good in the baseline wasn't PASS in the recording: "AD 3 State FREE Expanding nfs". It has an entry, recorded down the path it took. v2 had this case and "rm_tlbr".
Check
reference_archive.py fetchresolved rr_ssa, bng_nf and bng_ssa from the published release with their sha256s checked. rr_ssa's archive holds MODEL1102210001 and BIOMD0000000530.