Conversation
|
@joneugster May I have your attention please? |
|
Thanks for the PR! I'll try to have a closer look next week. I'm a bit confused why you want to delete or rename the existing .sh files Also if you extended the existing github actions (under |
|
the only reason why I rename them, so when you run I will take a look at |
|
@joneugster sorry for delay with Windows build, but can allow run this pipeline? |
|
I have approved, but if this just for testing purposes, I think it would be easier if you ran the actions on your own fork. The |
|
Hi @kant2002, sorry for dropping the ball on this! I've now merged #149 which adds a windows runner to CI to ensure the project can be built on windows. That PR doesn't port to process behind I think, if you'd want to do that, it might be best to have the window-build-logic under a script like Feel free to update and reopen this PR if you feel like adding Thanks very much for the PR, it was very useful! |
|
No worries. My goal was to be able build nng4 locally as smooth as possible so this is good thing |
No description provided.