Automate availability and add docs - #121
Merged
Merged
Conversation
ratheron
force-pushed
the
feature.availability_methods
branch
from
September 19, 2026 13:06
68bcac8 to
2d4f39e
Compare
ratheron
marked this pull request as ready for review
September 19, 2026 13:55
amacati
reviewed
Sep 19, 2026
| --> | ||
|
|
||
| All drone configurations are bundled with `crazyflow.dynamics`. Available configurations: `cf2x_L250`, `cf2x_P250`, `cf2x_T350`, `cf21B_500`, and any drone returned by `crazyflow.available_drones`. | ||
| All drone configurations are bundled with `crazyflow.dynamics`. Available configurations: `cf2x_L250`, `cf2x_P250`, `cf2x_T350`, `cf21B_500`, and any member of `crazyflow.Drone`. |
Collaborator
There was a problem hiding this comment.
Why are we listing four explicit models and then the generic one?
Collaborator
Author
There was a problem hiding this comment.
We should just say that all members of crazyflow.Drone are available and link the docs.
Co-authored-by: Martin Schuck <57562633+amacati@users.noreply.github.com>
Co-authored-by: Martin Schuck <57562633+amacati@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently hard code what drones are available. Also, there is no way to check what models are available for which dynamics and vice-versa (will be relevant for tests once #115 is done). Implemented both.
Additionally, there is a short section in the docs on how to add your own model.
Waiting for #119 to finish this