Repository navigation
Conversation
start_minimal only called window.minimize() once at startup. On a maximized window under KDE Plasma (Wayland) that request is not honoured, so an autostarted Thronium opened its window, and it never went to the tray. Hide the window like closing to the background does when a tray host is available (waiting briefly for it right after login), and keep minimizing only when there is no tray. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With Start minimized and Autostart enabled, Thronium opens its window on login instead of going to the tray (KDE Plasma, Wayland; tray works, the indicator is registered with
StatusNotifierWatcher).start_minimalonly callswindow.minimize()once onRunEvent::Ready. The saved geometry is restored (maximized: true) inwindow_geometry::restore, and the minimize request is not honoured for that window, so the window stays visible. Even when minimize works, the setting never put the app into the tray.Change
system_settings::readynow calls the newwindow_behavior::start_minimal.start_minimalhides the window the same way closing to the background does (background(app, can_hide)) when a tray host is available, and falls back to the previousminimize()when there is no tray.host_availableandbackgroundare nowpub(crate).The existing
watchloop still restores the window if the tray host disappears while it is hidden.Testing
Not built or run. I could not compile it locally, so please run CI / a local build. Behaviour to check: autostart with Start minimized on, with a tray host present (window hidden, reachable from the tray) and without one (window minimized).
🤖 Generated with Claude Code