Fix library loading and install firmware - #115
Open
jakecorrenti wants to merge 2 commits into
Open
Conversation
Assisted-by: Claude Code: opus-4.6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Add -add_rpath so @rpath/libkrun.dylib resolves at runtime. Install UEFI firmware to $(PREFIX)/share/krunkit. Assisted-by: Claude Code: opus-4.6 Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
|
thanks @jakecorrenti i suppose let the podman folks know when you release this? |
Collaborator
Author
Will do, just need @slp to get back from PTO to cut the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disable-library-validationr→disable-library-validation)-add_rpathtoinstall_name_toolso@rpath/libkrun.dylibresolves at runtime$(PREFIX)/share/krunkitso theinstalled binary can locate
KRUN_EFI.silent.fdThe
-changeflag alone doesn't handle the case where libkrun's install nameis
@rpath/libkrun.dylibrather than the barelibkrun.1.dylib. Adding-add_rpath $(PREFIX)/libcovers both patterns.The firmware was imported in ee24161 but the install target never
copied it to the prefix, so krunkit failed to find it at runtime.